Skip to content

Chore/fix android build#29921

Closed
adnxy wants to merge 3 commits into
mainfrom
chore/fix-android-build
Closed

Chore/fix android build#29921
adnxy wants to merge 3 commits into
mainfrom
chore/fix-android-build

Conversation

@adnxy
Copy link
Copy Markdown
Contributor

@adnxy adnxy commented May 8, 2026

Description

React Native 0.81's ReactAndroid/build.gradle.kts defaults to CMake 3.30.5 via System.getenv("CMAKE_VERSION") ?: "3.30.5". The Bitrise CI machines only ship CMake 3.22.1, and AGP cannot auto-download the missing version, causing [CXX1300] CMake '3.30.5' was not found build failures.

This PR adds the CMAKE_VERSION: '3.22.1' environment variable to bitrise.yml (app-level) and
build.yml (GitHub Actions) so the RN build uses the CMake version already installed. RN's CMakeLists
only require >= 3.13, so 3.22.1 is fully sufficient.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@adnxy adnxy added team-mobile-platform Mobile Platform team size-XS labels May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 8, 2026
@adnxy adnxy added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to CI infrastructure files: .github/workflows/build-android-e2e.yml (critical) and bitrise.yml. Although no application source code was modified, changes to the Android E2E workflow directly impact how Detox tests are built, executed, and reported in CI. This introduces systemic risk: build configuration, environment variables, caching, emulator setup, artifact handling, or test execution steps may affect all E2E suites.

Because this workflow is responsible for running Android E2E tests, the safest validation strategy is to execute the full smoke test suite to ensure:

  • The Android app builds correctly in CI
  • Detox setup and device/emulator boot works
  • Test sharding or tagging logic (if modified) does not exclude suites
  • No environment regressions affect specific feature areas (e.g., Snaps, Browser, Multi-chain, Seedless onboarding)

Since infrastructure changes can silently break subsets of tests (e.g., network mocking, feature flags, experimental builds like Card, Solana support, Snaps), running all smoke tags minimizes the risk of undetected CI regressions.

No application runtime logic was modified, so feature-specific narrowing is not appropriate here—the risk is cross-cutting across all test domains.

Performance tests are not required because:

  • No app source code changed
  • No UI, controller, rendering, or data-loading logic was modified
  • No performance test infrastructure under tests/performance/ was changed

Thus, only functional E2E validation of the CI pipeline is needed.

Performance Test Selection:
No application code or performance test infrastructure was modified. Workflow/CI changes do not affect runtime performance characteristics of the app itself.

View GitHub Actions results

@adnxy adnxy closed this May 8, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant